Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac(exchange) move bitswap -> exchange/bitswap #91

Closed
wants to merge 7 commits into from

Conversation

btc
Copy link
Contributor

@btc btc commented Sep 19, 2014

This move is large. Bringing it to your attention so it doesn't catch you by surprise..

main changes:

Move go-ipfs/bitswap package to go-ipfs/exchange/bitswap

  • Delineates the difference between the generic exchange interface and
    implementations (eg. BitSwap protocol)

    Thus, the bitswap protocol can be refined without having to overthink
    how future exchanges will work. Aspects common to BitSwap and other
    exchanges can be extracted out to the exchange package in piecemeal.

    Future exchange implementations can be placed in sibling packages next
    to exchange/bitswap. (eg. exchange/multilateral)

refac(exchange) rename exchange.Interface to match golang conventions

examples:
http://golang.org/pkg/container/heap/#Interface
http://golang.org/pkg/net/#Interface
http://golang.org/pkg/sort/#Interface

Brian Tiger Chow added 6 commits September 18, 2014 14:22
+ test that a partners wants are remembered by message receiver
Move go-ipfs/bitswap package to go-ipfs/exchange/bitswap

* Delineates the difference between the generic exchange interface and
  implementations (eg. BitSwap protocol)

  Thus, the bitswap protocol can be refined without having to overthink
  how future exchanges will work. Aspects common to BitSwap and other
  exchanges can be extracted out to the exchange package in piecemeal.

  Future exchange implementations can be placed in sibling packages next
  to exchange/bitswap. (eg. exchange/multilateral)
@btc btc added the status/in-progress In progress label Sep 19, 2014
didn't run tests after the refactor. apologies.
@btc btc mentioned this pull request Sep 20, 2014
@btc
Copy link
Contributor Author

btc commented Sep 20, 2014

already merged into net

@btc btc closed this Sep 20, 2014
@btc btc removed the status/in-progress In progress label Sep 20, 2014
@btc btc deleted the net-exchange-extract-bitswap branch October 22, 2014 23:06
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
@aschmahmann aschmahmann mentioned this pull request Dec 13, 2021
59 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
default config: add QUIC listening ports + quic to mars.i.ipfs.io
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
…ault_quic_listening

default config: add QUIC listening ports + quic to mars.i.ipfs.io
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…ault_quic_listening

default config: add QUIC listening ports + quic to mars.i.ipfs.io
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…ault_quic_listening

default config: add QUIC listening ports + quic to mars.i.ipfs.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant