WIP: update go-libp2p to v0.16.0 #8522

marten-seemann · 2021-10-21T11:38:39Z

This is still a draft, as it references a commit on master (go-libp2p v0.16.0 is not yet released).

vyzo · 2021-10-21T17:08:45Z

docs/config.md

+
+#### `Swarm.RelayServiceOpts.MaxReservationsPerPeer`
+
+Maximum number of reservations originating from the same peer.


we might want to explain how this is refreshed.

lidel

Refactored config and docs in this PR to follow go-ipfs-config changes from ipfs/go-ipfs-config#146.

docs/config.md

vyzo · 2021-10-27T09:44:01Z

don't we also want to optionally enable hole punching, at least when autorelay is enabled?

marten-seemann · 2021-10-27T10:34:31Z

don't we also want to optionally enable hole punching, at least when autorelay is enabled?

We probably want to get libp2p/go-libp2p#1214 merged. I'm not sure this is realistic before we the IPFS release is cut.

lidel · 2021-10-28T13:35:40Z

Circleci is working again so I've re-run yesterday's jobs. The GO-JS interop tests fail due to HOP request failed with code 270 and HOP_CANT_SPEAK_RELAY

Do we need to refactor tests so both ends to speak v2,
or is this broken and those tests have to be skipped until JS side implements v2?
(either way, I can help with tagging a new release of ipfs-interop, ping me if needed)

Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>

lidel · 2021-10-28T15:11:56Z

docs/config.md

+
+Time limit before a relayed connection is reset.
+
+Default: `"2m"`


💭 those "defaults" come from libp2p. Should we hardcode them in go-ipfs using WithDefaults?
Right now this PR uses 0 as placeholder and the actual default value that is delegated to go-ipfs, so if go-libp2p changes the defaults, docs will get out of date.

needed for sharness tests in ipfs/kubo#8522

adds Internal.Libp2pForceReachability needed for sharness tests in ipfs/kubo#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org>

lidel

Some config updates:

switched to the latest version of feat: Swarm.RelayService (circuit v2) go-ipfs-config#146 and updated docs to reflect recent changes
Internal.Libp2pForceReachability (OptionalString) should be available now, feel free to wire it up somewhere with forceReachability := cfg.Internal.Libp2pForceReachability.WithDefault("")

Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>

See ipfs/go-ipfs-config#146 and ipfs/go-ipfs-config@0fb5b58

This is for testing the libp2p release, since the context changes are not plumbed all the way through.

https://github.com/ipfs/go-ipfs-config/releases/tag/v0.18.0

…8559) * exit when Swarm.EnableRelayHop is set * chore: go-ipfs-config v0.18.0 Co-authored-by: Marcin Rataj <lidel@lidel.org>

lidel · 2021-11-23T22:03:46Z

Continued in #8563

Needed for: ipfs/kubo#8522

* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Marcin Rataj <lidel@lidel.org>

marten-seemann force-pushed the update-libp2p branch 5 times, most recently from cfe9509 to 65f6bfa Compare October 21, 2021 15:10

marten-seemann mentioned this pull request Oct 21, 2021

feat: Swarm.RelayService (circuit v2) ipfs/go-ipfs-config#146

Merged

marten-seemann force-pushed the update-libp2p branch from 65f6bfa to 1026be3 Compare October 21, 2021 17:03

vyzo self-requested a review October 21, 2021 17:05

vyzo reviewed Oct 21, 2021

View reviewed changes

lidel reviewed Oct 26, 2021

View reviewed changes

lidel requested changes Oct 26, 2021

View reviewed changes

docs/config.md Outdated Show resolved Hide resolved

lidel mentioned this pull request Oct 26, 2021

feat: add an OptionalDuration type ipfs/go-ipfs-config#148

Merged

lidel force-pushed the update-libp2p branch from 5028566 to 69cc041 Compare October 27, 2021 18:03

This comment has been minimized.

Sign in to view

lidel added a commit that referenced this pull request Oct 28, 2021

docs(config): circuit relay v2

8827093

Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>

lidel reviewed Oct 28, 2021

View reviewed changes

lidel force-pushed the update-libp2p branch from 8c7a1f5 to 7bb35e7 Compare October 28, 2021 15:27

lidel mentioned this pull request Oct 28, 2021

feat: flag for ForceReachability mode in libp2p ipfs/go-ipfs-config#150

Merged

lidel added a commit to ipfs/go-ipfs-config that referenced this pull request Oct 28, 2021

feat: Internal.Libp2pForceReachability

91a83cf

needed for sharness tests in ipfs/kubo#8522

lidel added a commit to ipfs/go-ipfs-config that referenced this pull request Oct 28, 2021

feat: flag for ForceReachability mode in libp2p (#150)

a25573d

adds Internal.Libp2pForceReachability needed for sharness tests in ipfs/kubo#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org>

lidel reviewed Oct 28, 2021

View reviewed changes

lidel self-requested a review October 28, 2021 23:24

marten-seemann pushed a commit that referenced this pull request Oct 30, 2021

docs(config): circuit relay v2

a33baca

Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>

marten-seemann force-pushed the update-libp2p branch from b05c673 to 1741a58 Compare October 30, 2021 14:03

marten-seemann and others added 3 commits November 12, 2021 21:27

WIP: update go-libp2p to v0.16.0

378b416

WIP relay config

61d93d9

refactor: apply config changes from review

3aa2cfd

See ipfs/go-ipfs-config#146 and ipfs/go-ipfs-config@0fb5b58

marten-seemann force-pushed the update-libp2p branch from c0c40eb to 9e27b76 Compare November 14, 2021 10:22

lidel mentioned this pull request Nov 15, 2021

feat: Addresses.AppendAnnounce #8177

Merged

marten-seemann and others added 3 commits November 16, 2021 15:13

use configuration option for static relays

0e7e5e1

update sharness

dea5469

plumb through pseudoversions for context changes

4142b46

This is for testing the libp2p release, since the context changes are not plumbed all the way through.

marten-seemann force-pushed the update-libp2p branch from 9e27b76 to 4142b46 Compare November 16, 2021 11:15

marten-seemann and others added 3 commits November 16, 2021 15:26

fix StaticRelay config option

925f7d7

update go-libp2p

97993d8

plumb through pseudoversions for context changes

5358b0d

This is for testing the libp2p release, since the context changes are not plumbed all the way through.

marten-seemann force-pushed the update-libp2p branch from 3da98d5 to fde7d01 Compare November 17, 2021 12:28

update go-ipfs-config to v0.17.0, fix sharness

b526b28

marten-seemann force-pushed the update-libp2p branch from fde7d01 to b526b28 Compare November 17, 2021 12:35

lidel mentioned this pull request Nov 17, 2021

feat: go-libp2p v0.16.0 ipfs/interop#398

Closed

4 tasks

add docs for Swarm.RelayClient configuration

3267832

This was referenced Nov 19, 2021

feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set #8559

Merged

feat: Swarm.EnableHolePunching flag #8562

Merged

marten-seemann added this to the go-ipfs 0.11 milestone Nov 22, 2021

aschmahmann mentioned this pull request Nov 22, 2021

feat: go-libp2p 0.16 and autosharding and go-datastore to take contexts #8563

Merged

guseggert mentioned this pull request Nov 23, 2021

Release v0.11 #8343

Closed

80 tasks

marten-seemann and others added 3 commits November 23, 2021 21:35

use LIBP2P_TCP_REUSEPORT instead of IPFS_REUSEPORT

e9c5347

chore: go-ipfs-config v0.18.0

f8e80e2

https://github.com/ipfs/go-ipfs-config/releases/tag/v0.18.0

feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set (#…

d510aa3

…8559) * exit when Swarm.EnableRelayHop is set * chore: go-ipfs-config v0.18.0 Co-authored-by: Marcin Rataj <lidel@lidel.org>

lidel closed this Nov 23, 2021

lidel mentioned this pull request Nov 26, 2021

Create a way for people to migrate peerid from go-ipfs libp2p/go-libp2p-relay-daemon#5

Closed

lidel added a commit to ipfs/interop that referenced this pull request Nov 29, 2021

feat: circuit relay v2

278e2a0

Needed for: ipfs/kubo#8522

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: update go-libp2p to v0.16.0 #8522

WIP: update go-libp2p to v0.16.0 #8522

marten-seemann commented Oct 21, 2021

vyzo Oct 21, 2021

lidel left a comment

vyzo commented Oct 27, 2021

marten-seemann commented Oct 27, 2021

lidel commented Oct 28, 2021

This comment has been minimized.

lidel Oct 28, 2021

lidel left a comment •

edited

Loading

lidel commented Nov 23, 2021


		#### `Swarm.RelayServiceOpts.MaxReservationsPerPeer`

		Maximum number of reservations originating from the same peer.


		Time limit before a relayed connection is reset.

		Default: `"2m"`

WIP: update go-libp2p to v0.16.0 #8522

WIP: update go-libp2p to v0.16.0 #8522

Conversation

marten-seemann commented Oct 21, 2021

vyzo Oct 21, 2021

Choose a reason for hiding this comment

lidel left a comment

Choose a reason for hiding this comment

vyzo commented Oct 27, 2021

marten-seemann commented Oct 27, 2021

lidel commented Oct 28, 2021

This comment has been minimized.

lidel Oct 28, 2021

Choose a reason for hiding this comment

lidel left a comment • edited Loading

Choose a reason for hiding this comment

lidel commented Nov 23, 2021

lidel left a comment •

edited

Loading