feat(ci): attach release assets from dist.ipfs.io #8494
Conversation
Fetching only what we need + triggering a smoke-test against 0.10.0-rc1
lidel
changed the title
lidel
changed the title
There was a problem hiding this comment.
LGTM, thank you @petar ❤️
Ready to be merged.
TODO
- smoke test
- switch CI trigger to cron+manual
Smoke-test result: 👍
I tested it end-to-end with 0.10.0-rc1 (removed all assets just to see if we hit any performance issue when 50 files need to be uploaded). There were no issues, sync took 3 minutes and all missing assets got attached correctly to v0.10.0-rc1:
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 0 * * *' |
There was a problem hiding this comment.
ℹ️ the sync will run once a day and sync the latest 5 releases, but also can be triggered manually if needed (eg. when maintainer knows the assets for newly added release just got added to dist.ipfs.io)
@aschmahmann does this look good? if so, we can merge this.
| restore-keys: | | ||
| ${{ runner.os }}-go- | ||
| - name: Build go-ipfs binary | ||
| run: go install github.com/ipfs/go-ipfs/cmd/ipfs@latest |
There was a problem hiding this comment.
ℹ️ my understanding is this will always use the latest release, which should be more stable than using the latest master. I've added cache so all deps are fetched only once:
| first run | second run, with cache |
|---|---|
 |
 |
I think we could just fetch binary from dist.ipfs.io, but i'm fine either way.
💭 This and starting, waiting for go-ipfs node, all are steps which we duplicate across workflows. We will most likely extract these reusable steps into a separate action (@BigLep – fysa this will be another good onboarding task for Piotr 🔧 ✨ )
There was a problem hiding this comment.
ACK on generic action: #8511
This reuses work from ipfs/kubo#8494
* feat: attach signed binaries to gh releases reuses work from ipfs/kubo#8494 but skips prereleases.
Addresses #8316.