fix: macos notarized fs-repo-migrations #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/macos-notarized-migrations
branch
from
7479857
to
97692a5
Compare
This was referenced Aug 9, 2021
aschmahmann
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates go-ipfs to use signed migrations on macOS.
Uses: https://github.com/ipfs/fs-repo-migrations/releases/tag/v2.0.2 signed in ipfs/distributions#381
Closes #8240
cc @autonome @bbondy @spylogsster – fysa the plan is for this to land in go-ipfs 0.10
Smoke-test passed ok 👍
All good, confirmed this works as expected in Brave (without fs-repo-10-to-11 signed by Brave):
Unsigned binary blocked by macOS
With signed migrations from this PR
IPFS_DIST_PATH=/ipfs/QmP7tLxzhLU1KauTRX3jkVkF93pCv4skcceyUYMhf4AKJRworks fine: