ds-query + ipfs refs local #531
Conversation
RFCR, but NOT ready for merge. |
|
Are resources reclaimed when clients don't read all results? |
|
Major changes. Includes the new and improved Also, I made the commands library pass a context -- right now it's pretty ugly, but will get removed soon. |
|
<3 Ill CR |
| // * spawn another goroutine that waits on <-child.Closed() | ||
| // | ||
| // go func() { | ||
| // <-child.Closed() |
There was a problem hiding this comment.
Should probably update this comment to reflect the new strategy
|
jenkins aborted the last test: https://build.protocol-dev.com/job/all-the-tests/489/ -- https://build.protocol-dev.com/job/network-test/673/console -- any idea why @briantigerchow ? |
ipfs blocks local returns _all_ local refs. For now this is one long op. future commits will make it async.
|
jenkins acting up again: https://build.protocol-dev.com/job/all-the-tests/496/ way too many commits there, it should only be f9ca67e...e244fff (as of this message) |
|
@jbenet ive seen that before, where jenkins has a TON of commits on its plate.. no idea why |
|
I'm going to merge this. warning to users: datastore migration neededAfter this commit, you wont be able to get the data, as the format changed a bit. If you'd like to make sure you dont get problems, and you can use the data, bug me here or on irc for a migration script. (happy to write one if someone needs it). |
This command introduces datastore.Query and
ipfs refs local, which is a commant that simply
lists all refs stored locally.
HUGE WARNING: this commit changes how blocks are stored,
making all past blocks unlikely to be read. I am considering
putting in place an "upgrade" script to make sure everyone's
operation continues soundly. We'll need things like this in
place later on.