Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/ipfs: error out on invalid routing option #3482

Merged
merged 1 commit into from
Dec 8, 2016

Conversation

whyrusleeping
Copy link
Member

closes #3459

License: MIT
Signed-off-by: Jeromy why@ipfs.io

Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently default is the normal DHT, we should have defualt option for that and then case matching it, also sharness test for the not defined routing would be good.

@Kubuxu
Copy link
Member

Kubuxu commented Dec 8, 2016

@whyrusleeping
Copy link
Member Author

Of course that would be the case, i checked ipfs daemon --routing=foobar and it failed as expected...

@whyrusleeping
Copy link
Member Author

@Kubuxu fixed

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping whyrusleeping merged commit e9215a6 into master Dec 8, 2016
@whyrusleeping whyrusleeping deleted the fix/daemon-routing-opt-chk branch December 8, 2016 21:33
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 8, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing flag to ipfs daemon command accepts non-existing routings
2 participants