Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for flags package #3449

Merged
merged 1 commit into from
Nov 30, 2016
Merged

Add test for flags package #3449

merged 1 commit into from
Nov 30, 2016

Conversation

zmackie
Copy link
Contributor

@zmackie zmackie commented Nov 30, 2016 •
edited
Loading

To address the flags coverage in #3053.

@zmackie
Add test for flags.
4e05f07 
License: MIT
Signed-off-by: Zander Mackie <zmackie@gmail.com>
@whyrusleeping
Copy link
Member

wow, thats clever 👍

@Kubuxu
Copy link
Member

Kubuxu commented Nov 30, 2016

That was my reaction too.

@zmackie
Copy link
Contributor Author

zmackie commented Nov 30, 2016 •
edited
Loading

Generally I'm not into clever, but I did learn this reading effective go... so ¯_(ツ)_/¯.

@whyrusleeping whyrusleeping merged commit 8a1aa98 into ipfs:master Nov 30, 2016
@whyrusleeping
Copy link
Member

Thanks @Zanadar, youre fighting the good fight :)

@zmackie zmackie deleted the test/flags-test branch November 30, 2016 22:33
@ghost ghost mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmackie @whyrusleeping @Kubuxu