make path resolver no longer require whole node for construction #3321
+161
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/resolver-refactor
branch
2 times, most recently
from
26f42c4
to
67c2a4e
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
added
need/review
|
LGTM |
ghost
mentioned this pull request
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
make path resolver no longer require whole node for construction This commit was moved from ipfs/kubo@17c629d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some preliminiary work before we can get sharding in. Resolving a path now requires a certain bit of context and logic around what the path actually refers to (unixfs vs normal dag traversal)
License: MIT
Signed-off-by: Jeromy why@ipfs.io