Bitswap #32
Merged
Bitswap #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| u "github.com/jbenet/go-ipfs/util" | ||
| ) | ||
|
|
||
| type mesListener struct { | ||
| type MesListener struct { |
There was a problem hiding this comment.
stylistic: can probably spell it out as swarm.MessageListener (clearer to people unfamiliar with how things work, etc)
| return nil, errors.New("not implemented") | ||
| func (bs *BitSwap) HaveBlock(k u.Key) error { | ||
| return bs.routing.Provide(k) | ||
| } |
There was a problem hiding this comment.
Missing here is that we could be tracking our partners last-received wantlists, so we could see who wants this block and send it right away. I'm not too sure about this, may be premature optimization, because it could waste lots of bandwidth for reducing latency. this will be impt to test/model.
There was a problem hiding this comment.
agreed. We can probably just spin off a goroutine to check and manage sending all that information.
There was a problem hiding this comment.
(fix to above: ledger already has ledger.WantList)
ribasushi
pushed a commit
that referenced
this pull request
Jul 4, 2021
Implement ForeachBaggageItem
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Remove diaglock as per ipfs#26
longfeiWan9
pushed a commit
to longfeiWan9/go-ipfs
that referenced
this pull request
Nov 18, 2021
update contributing link
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
add an experiment to prefer TLS 1.3 over secio
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…-tls add an experiment to prefer TLS 1.3 over secio
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…-tls add an experiment to prefer TLS 1.3 over secio
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…-tls add an experiment to prefer TLS 1.3 over secio
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Apr 7, 2022
gx publish 1.1.36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.