bitswap: add ledger subcommand

[atomgardner]

Bring on the Strategies.

[whyrusleeping]

please take a look at #2814

[RichardLitt]

These should all be initially capitalized, I think.

[atomgardner]

Hi @whyrusleeping, is findOrCreate really necessary? If the ledger doesn't exist, is there any reason to have this command create one?

[whyrusleeping]

@thomas-gardner The find or create is necessary for the function of the bitswap code. Its an atomic operation to fetch the ledger for a peer (and create one while holding the lock if it doesnt exist).

Also, this PR is mostly a duplicate of #2814

[atomgardner]

@whyrusleeping---right, something about creating an unneeded ledger was confusing to me, but I can see how using `findOrCreate` keeps things tidy and atomic. Re diff #2814, this PR doesn't export any of the `Bitswap` fields, & gets the locking right now ( ...I hope.)

[whyrusleeping]

@thomas-gardner alright, if you could add a ShortDescription to the command and rebase this on master i'll get it merged in.

[jbenet]

Nice!
On Thu, Aug 4, 2016 at 10:19 Jeromy Johnson notifications@github.com
wrote:

@thomas-gardner https://github.com/thomas-gardner alright, if you could
add a ShortDescription to the command and rebase this on master i'll get
it merged in.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2852 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIcobMlApfhZBX3GYu5nBvpo8HPDDVhks5qcfTqgaJpZM4I08_h
.

[jbenet]

We should move bitswap out into go-bitswap so it can get dev cycles faster
than in go-ipfs. Can write small tools to test it and leverage it so it can
evolve quickly and merge back into go-ipfs as needsd
On Thu, Aug 4, 2016 at 17:23 Juan Benet juan2@benet.ai wrote:

Nice!
On Thu, Aug 4, 2016 at 10:19 Jeromy Johnson notifications@github.com
wrote:

@thomas-gardner https://github.com/thomas-gardner alright, if you
could add a ShortDescription to the command and rebase this on master
i'll get it merged in.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2852 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIcobMlApfhZBX3GYu5nBvpo8HPDDVhks5qcfTqgaJpZM4I08_h
.

[atomgardner]

Jeromy Johnson:

@thomas-gardner alright, if you could add a ShortDescription to the
command and rebase this on master i'll get it merged in.

Rebased & added.

[whyrusleeping]

alright, LGTM