Skip to content

Commit

Permalink
fix security comment #92
Browse files Browse the repository at this point in the history
  • Loading branch information
jbenet committed Sep 20, 2014
1 parent d994aff commit e57275f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion cmd/ipfs/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ func initCmd(c *commander.Command, inp []string) error {
return err
}

// pretend to encrypt key, then store it unencrypted
// currently storing key unencrypted. in the future we need to encrypt it.
// TODO(security)
skbytes, err := sk.Bytes()
if err != nil {
return err
Expand Down
3 changes: 2 additions & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ func (i *Identity) DecodePrivateKey(passphrase string) (crypto.PrivateKey, error
return nil, err
}

//pretend to actually decrypt private key
// currently storing key unencrypted. in the future we need to encrypt it.
// TODO(security)
return x509.ParsePKCS1PrivateKey(pkb)
}

Expand Down

0 comments on commit e57275f

Please sign in to comment.