Switch unixfs.Metadata.MimeType to optional

*** THIS IS A BREAKING CHANGE *** as per [1]: "Required is forever" Nevertheless this seems like a good idea at this time: there are no known producers ( nor consumers ) of MetaData nodes, and the current requirement of MimeType has an extremely narrow application scope. This change could very well be rejected in lieu of implementing a new type of node ( e.g. TheRealMetadata ) in the DataType enum. Based on #3451 (comment) License: MIT Signed-off-by: Mib Kd743naq <mib.kd743naq@gmail.com> [1] https://developers.google.com/protocol-buffers/docs/proto#specifying-field-rules
ipfs · Dec 2, 2016 · 8ee4280 · 8ee4280 · GitCop · Dec 2, 2016
1 parent a7abc9c
commit 8ee4280
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/unixfs/pb/unixfs.pb.go b/unixfs/pb/unixfs.pb.go
diff --git a/unixfs/pb/unixfs.proto b/unixfs/pb/unixfs.proto
@@ -16,5 +16,5 @@ message Data {
 }
 
 message Metadata {
-	required string MimeType = 1;
+	optional string MimeType = 1;
 }