This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
jsipfs block http-api and cli #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @diasdavid, of course. What should I be doing next? |
|
Related to #50 |
|
@RichardLitt didn't the "Good foundations" section on #30 (comment) helped? Let's chat today to clear out any questions :) |
|
Ah, that's interesting. I'll take a look through this again and see what I can do. |
|
@RichardLitt do you still need some help here? |
|
ping @RichardLitt |
fbaiodias
added
needs review
and removed
help wanted
kind/support
|
Just finished implementing this, ping @diasdavid |
|
|
||
| const mh = utils.isDaemonOn() | ||
| ? key | ||
| : new Buffer(bs58.decode(key)) |
There was a problem hiding this comment.
soon all these hacks will be gone (once we get core spec \o/)
daviddias
changed the title
|
@xicombd sweet! Great work :D Only one comment :) |
This was referenced Dec 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I stubbed out a couple of files, but I'm not sure this is what I am actually supposed to be doing here. It is hard without more examples, and I don't know how to run, or what sort of development environment I should be using to test the code as I go along.