This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix(ipfs-core-types): top OptionExtension
#3749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for opening this and the other PRs. You haven't added a description so it's unclear why you wish to make the change so it's hard to review. It's causing CI failures so it cannot be merged without further work. Can you please for this and all future PRs, add a description that clearly states:
|
This was referenced Jul 27, 2021
achingbrain
added a commit
that referenced
this pull request
Jul 27, 2021
Member
|
Fixed by #3763 |
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
… (#3763) Bubbles the `OptionExtension` up to the root type for use by the HTTP client and exports an interface for use by consuming modules. Supersedes #3749 and #3736
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.