This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: ignore typecheck for onFinishCommand #3353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a ts-ignore for the yargs `onFinishCommand` method as otherwise building fails with:
```
Property 'onFinishCommand' does not exist on type 'Argv<{ silent: boolean; } & { pass: string; } & { migrate: boolean; } & { api: string | undefined; }>'
```
|
@Gozala I don't really want to merge this, any idea what's causing this to happen? To replicate, just run |
|
I can't replicate this now, closing. |
achingbrain
pushed a commit
that referenced
this pull request
Oct 28, 2020
This was prompted by #3353. I am guessing that something end up pulling old version of `@types/yargs` that was unaware of `onFinishCommand`. This pull explicitly adds latest `@types/yargs` into `ipfs-cli` dev dependencies which: 1. Seems to be aware of `onFinishCommand`. 2. Makes ipfs-cli aware of yargs interface, which without this just appears as `any`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ts-ignore for the yargs
onFinishCommandmethod as otherwise building fails with: