This repository was archived by the owner on Feb 12, 2024. It is now read-only.
dht.provide() should accept string keys (#2573) #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed because of a linting issue |
|
Pushed a fix |
alanshaw
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Code change LGTM. It would be rad to get a test added for this in the interface-ipfs-core tests.
You could probably copy+paste this test and remove the new CID part https://github.com/ipfs/interface-js-ipfs-core/blob/b4c3ce6d1aac503f05e301c4f09d0590511384ca/src/dht/provide.js#L79-L90.
|
I'll do it |
|
Thanks @reasv 🥰 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #2573
ipfs.dht.provide() now accepts strings as well as CID objects, and attempts to convert them to the latter.