Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: allow controlling preload behaviour from cli #2384

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 22, 2019

Pulled out from #2379

Depends on:

@alanshaw
Copy link
Member

Should this be exposed in the HTTP API? Otherwise this won't work when talking to a daemon. Also, should ipfs daemon --enable-preload=false take precedence?

@achingbrain
Copy link
Member Author

Should this be exposed in the HTTP API?

Good point, I have added this.

Should ipfs daemon --enable-preload=false take precedence?

Not sure. I guess maybe if you've specified it explicitly?

@achingbrain
Copy link
Member Author

Exposed in ipfs-http-client here: ipfs-inactive/js-ipfs-http-client#1079

@alanshaw
Copy link
Member

Should ipfs daemon --enable-preload=false take precedence?

Not sure. I guess maybe if you've specified it explicitly?

Just looked in the preload component and this happens already. If you start the daemon with --enable-preload=false then specifying preload: true here will have no effect.

Alan Shaw added 2 commits August 23, 2019 14:58
@alanshaw alanshaw merged commit 5878a0a into master Aug 23, 2019
@alanshaw alanshaw deleted the add-preload-cli-arg branch August 23, 2019 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants