Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

perf: lower connection manager limits #1926

Merged
merged 1 commit into from
Mar 14, 2019
Merged

perf: lower connection manager limits #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
perf: lower connection manager limits 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
  • Loading branch information
Alan Shaw committed Mar 13, 2019
commit a34234727582ff78486e8a0d56aa566811f67ed2
4 changes: 2 additions & 2 deletions src/core/runtime/config-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ module.exports = () => ({
],
Swarm: {
ConnMgr: {
LowWater: 600,
HighWater: 900
LowWater: 200,
HighWater: 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try this, but I think 500 is going to end up being too high for the browser. I think it's more reasonably going to be in the range of 50-200.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to get some testing done for this in the browser and adjust it accordingly, for now just setting it to be the same as Node.js.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while it is not enabled in the browser, I think it is fine to be the same

}
}
})
4 changes: 2 additions & 2 deletions src/core/runtime/config-nodejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ module.exports = () => ({
],
Swarm: {
ConnMgr: {
LowWater: 600,
HighWater: 900
LowWater: 200,
HighWater: 500
}
}
})