Safari Support

[lightninglu10]

• Version: 0.25.0
• Platform: JS
• Subsystem:

Type: Bug

Severity: High

Description: IPFS does not work in Safari. It looks like something dealing with the webcrypto package here: libp2p/js-libp2p-crypto#18

Getting an error in Safari that

alg — ipfs.min.js:42864SyntaxError: Bad algorithm name

Is there anyway to remedy this?

[lightninglu10]

Tracked it down to an algorithm named ECDH in this part of the code:

function alg(a) {
            var r = {
                name: (a.name || a || "").toUpperCase().replace("V", "v")
            };
            switch (r.name) {
            case "SHA-1":
            case "SHA-256":
            case "SHA-384":
            case "SHA-512":
                break;
            case "AES-CBC":
            case "AES-GCM":
            case "AES-KW":
                a.length && (r.length = a.length);
                break;
            case "HMAC":
                a.hash && (r.hash = alg(a.hash)), a.length && (r.length = a.length);
                break;
            case "RSAES-PKCS1-v1_5":
                a.publicExponent && (r.publicExponent = new Uint8Array(a.publicExponent)), a.modulusLength && (r.modulusLength = a.modulusLength);
                break;
            case "RSASSA-PKCS1-v1_5":
            case "RSA-OAEP":
                a.hash && (r.hash = alg(a.hash)), a.publicExponent && (r.publicExponent = new Uint8Array(a.publicExponent)), a.modulusLength && (r.modulusLength = a.modulusLength);
                break;
            default:
                throw new SyntaxError("Bad algorithm name")
            }
            return r
        }

[daviddias]

Thanks for reporting this @lightninglu10. It is a known issue for a while as we focused on developing for Chrome and Firefox (due to their WebRTC support). See compat table here: libp2p/js-libp2p-crypto#18

This means that missing alg need to be shimmed. Is this something you would like to help with?

[bertrandrustle]

A major version of Safari (11.0) was released a couple of weeks ago. The WebCrypto API section of the release notes is a little vague and the JS API docs are even less informative, but the release appears to include recent commits to WebKit adding support for the remaining WebCrypto spec ciphers mentioned in libp2p/js-libp2p-crypto#18. See:

https://bugs.webkit.org/show_bug.cgi?id=166746
https://bugs.webkit.org/show_bug.cgi?id=160880
https://trac.webkit.org/browser/webkit/releases/Apple/Safari%2011.0/WebCore/crypto/algorithms

[daviddias]

Do we have a volunteer to go and test these new grounds? Thank you for the update, @bertrandrustle