Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Awesome Endeavour - Correct libp2p-webrtc-star situation #981

Closed
@daviddias

Description

@daviddias

Following the ☕️💬 between @diasdavid and @lgierth https://github.com/ipfs/pm/pull/492/files#r136710447

  • libp2p-webrtc-star should encapsulate another multiaddr (as described in the issue) and that means that a /libp2p-webrtc-star/dns4/star-signal.cloud.ipfs.team/wss/ipfs/<your-peer-id> should in fact be /dns4/star-signal.cloud.ipfs.team/wss/libp2p-webrtc-star/ipfs/<your-peer-id>. This requires
    • Updating js-mafmt
    • Bubble up all the changes through the dep tree
  • Change libp2p-webrtc-star to p2p-webrtc-star (so that it matches the nomenclature also used by p2p-circuit)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions