Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

there is no assets subdirectory #418

Closed
Mithgol opened this issue Aug 16, 2016 · 2 comments
Closed

there is no assets subdirectory #418

Mithgol opened this issue Aug 16, 2016 · 2 comments

Comments

@Mithgol
Copy link
Contributor

Mithgol commented Aug 16, 2016

Currently README.md recommends the following:

<script type="text/javascript" src="assets/bundled.js"></script>

However,

  • HTML5 script defaults to type="text/javascript" and thus that attribute can be dropped from the example,
  • there is no assets subdirectory in the results of npm install ipfs and thus the path assets/bundled.js should be replaced by dist/index.min.js if appropriate.
@daviddias
Copy link
Member

Seems that his is a leftover of pre 'dist' era. Currently, the installation method is the same for all the ipfs modules, that is:

image

As seen in : https://github.com/multiformats/js-multihash#in-the-browser-through-script-tag

@Mithgol would you like to submit a PR to fix that?

Thank you

@Mithgol
Copy link
Contributor Author

Mithgol commented Aug 16, 2016

Ok, here it goes.

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants