Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

go-ipfs returns success when pinging with unknow peer id #2186

Closed
hugomrdias opened this issue Jun 19, 2019 · 3 comments
Closed

go-ipfs returns success when pinging with unknow peer id #2186

hugomrdias opened this issue Jun 19, 2019 · 3 comments
Assignees
@achingbrain
Labels
exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up

Comments

@hugomrdias
Copy link
Member

go ipfs version 0.4.21

https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/ping/ping-pull-stream.js#L62
https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/ping/ping-readable-stream.js#L70
https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/ping/ping.js#L55

These tests are skipped in http-client until we find what changed and either fix the problem or replicate here in js-ipfs.
@hugomrdias hugomrdias added exp/expert Having worked on the specific codebase is important exploration P1 High: Likely tackled by core team if no one steps up labels Jun 19, 2019
@hugomrdias hugomrdias mentioned this issue Jun 19, 2019
Merged
@daviddias
Copy link
Member

@Stebalien any clue on what changed?

@Stebalien
Copy link
Member

ipfs/kubo#6312?

We switched to returning an actual error so the command would exit with a non-zero exit status on failure.

Bug: ipfs/kubo#6298

@achingbrain
Copy link
Member

Closing as we are not maintaining compatibility with the Kubo API in future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@achingbrain achingbrain

Labels
exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
js-ipfs deprecation
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Stebalien @hugomrdias @achingbrain @daviddias