Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

ipfs name resolve with recursive default to true makes name-pubsub fail #2001

Closed
@hugomrdias

Description

@hugomrdias
  • Version:master
  • Platform:all
  • Subsystem:name

Type:Bug

Severity: High

Description:

go-ipfs changed the default value for the recursive option in ipfs name resolve, so we should do the same.

But in js-ipfs name-pubsub tests fail, with recursive === true.

Steps to reproduce the error:

default to true in these places:
https://github.com/ipfs/js-ipfs/blob/master/src/cli/commands/name/resolve.js#L21
https://github.com/ipfs/js-ipfs/blob/master/src/http/api/resources/name.js#L10
https://github.com/ipfs/js-ipfs/blob/master/src/core/components/name.js#L130

/cc @vasco-santos

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High: Likely tackled by core team if no one steps upexp/expertHaving worked on the specific codebase is importantkind/bugA bug in existing code (including security flaws)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions