`ipfs.dag.put` should be happy if i don't give it options

[whyrusleeping]

simply running:

ipfs.dag.put(thing, (e, v) => {
  console.log(e,v)
})

Doesnt work right now, because it wants the put options struct.

[fsdiogo]

According to the dag.put spec the options are required. We could have some defaults to make it optional though.

[alanshaw]

An options object should always be optional IMHO. This needs to be fixed.

[0x-r4bbit]

@alanshaw I'd like to give this a spin in case nobody is working on this yet.

While looking into this, some questions came up regarding the testing environment:

• Tests for this API are written in interface-ipfs-core, so I assume, this would be the place to a have spec that makes options optional (and introduces decent defaults)
• However, tests are executed within the jsipfs repo, so to have this fixed and tested, we need to touch two repositories. What's your way to go about this? Shall I first send a PR to the interface repo and once landed and published have jsipfs depend on the newer version so it can fulfill the new spec?
• As I'm new to this field, I can't say what those decent defaults would be. So any pointers on what the defaults should look like would be great.

Last but not least I noticed from the documentation that a subset of tests can be run using e.g.

test.dag(common, { only: true })

This doesn't seem to work, as npm run test:node:core still executes the entire core testsuite and basically ignores the only option.

I guess this is either a bug or I'm using the API wrong and probably this should be discussed in the interface repo. Hope you have some insights on that! :)

Thanks!

[alanshaw]

@PascalPrecht that would be awesome if you had a go.

You can write your tests in interface-ipfs-core, and use npm link to enable you to run your tests against your code in js-ipfs.

At the moment I've not been able to merge the PRs that enable the only skip so for the time being if you branch off of #1389 then you should be able to rebase when it's merged (hopefully very soon).

Let me know if any of that is unclear!

[0x-r4bbit]

@alanshaw thanks for the super quick feedback!

Everything's crystal clear 👌

PR in the making...