Uncaught Error: Can't set property: 'links' is immutable

[haadcode]

After updating to 0.27.0 and running in the browser, there's an error that didn't happen before:

Uncaught Error: Can't set property: 'links' is immutable
    at module.exports.set links [as links] (index.min.js:1)
    at Object.Buffer.serialize (index.min.js:1)
    at cb (index.min.js:1)
    at nextTask (index.min.js:1)
    at exports.default (index.min.js:1)
    at IPLDResolver._put (index.min.js:1)
    at IPLDResolver.put (index.min.js:1)
    at DAGNode.create (index.min.js:1)
    at multihashing (index.min.js:1)
    at Multihashing.Multihashing.digest (index.min.js:1)

Version: 0.27.0
Platform: Browser

This happens upon starting IPFS, but it never starts as the error is thrown. Doesn't happen with 0.26.0.

Full stack trace for what it's worth (index.min.js is ipfs/dist/index.min.js):

set links @ index.min.js:1
Buffer.serialize @ index.min.js:1
cb @ index.min.js:1
nextTask @ index.min.js:1
exports.default @ index.min.js:1
_put @ index.min.js:1
put @ index.min.js:1
DAGNode.create @ index.min.js:1
multihashing @ index.min.js:1
Multihashing.Multihashing.digest @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ orbitdb.min.js:1
i @ orbitdb.min.js:1
n @ orbitdb.min.js:1
postMessage (async)
o @ orbitdb.min.js:1
u.setImmediate @ orbitdb.min.js:1
(anonymous) @ index.min.js:1
Promise resolved (async)
nodeify @ index.min.js:1
(anonymous) @ index.min.js:1
sha2256 @ index.min.js:1
Multihashing.digest @ index.min.js:1
Multihashing @ index.min.js:1
serialize @ index.min.js:1
Buffer.serialize @ index.min.js:1
module.exports @ index.min.js:1
new.promisify @ index.min.js:1
(anonymous) @ index.min.js:1
cb @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
exports.default @ index.min.js:1
exports.default @ index.min.js:1
exports.default @ index.min.js:1
cb @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
closed.err @ index.min.js:1
(anonymous) @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
closed.cb @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
closed.waterfall @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
callback @ index.min.js:1
setImmediate @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ orbitdb.min.js:1
i @ orbitdb.min.js:1
n @ orbitdb.min.js:1
postMessage (async)
o @ orbitdb.min.js:1
u.setImmediate @ orbitdb.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
module.exports @ index.min.js:1
closed.cb @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
closed.waterfall @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
setImmediate @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ orbitdb.min.js:1
i @ orbitdb.min.js:1
n @ orbitdb.min.js:1
postMessage (async)
o @ orbitdb.min.js:1
u.setImmediate @ orbitdb.min.js:1
(anonymous) @ index.min.js:1
exports.lock @ index.min.js:1
closed.cb @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
parallel @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
iterateeCallback @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
get @ index.min.js:1
store.get @ index.min.js:1
(anonymous) @ index.min.js:1
req.onsuccess @ index.min.js:1
IndexedDB (async)
Level._get @ index.min.js:1
AbstractLevelDOWN.get @ index.min.js:1
LevelUP.get @ index.min.js:1
get @ index.min.js:1
get @ index.min.js:1
check @ index.min.js:1
version @ index.min.js:1
(anonymous) @ index.min.js:1
replenish @ index.min.js:1
(anonymous) @ index.min.js:1
exports.default @ index.min.js:1
(anonymous) @ index.min.js:1
exports.default @ index.min.js:1
exports.default @ index.min.js:1
exports.default @ index.min.js:1
_isInitialized @ index.min.js:1
closed.cb @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
err @ index.min.js:1
(anonymous) @ index.min.js:1
Item.run @ index.min.js:1
drainQueue @ index.min.js:1
setTimeout (async)
runTimeout @ index.min.js:1
process.nextTick @ index.min.js:1
LevelUP.open @ index.min.js:1
open @ index.min.js:1
closed.cb @ index.min.js:1
nextTask @ index.min.js:1
exports.default @ index.min.js:1
open @ index.min.js:1
waterfall @ index.min.js:1
nextTask @ index.min.js:1
next @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
replenish @ index.min.js:1
iterateeCallback @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
(anonymous) @ index.min.js:1
tx.oncomplete @ index.min.js:1

[daviddias]

@haadcode that property has been immutable for a while https://github.com/ipld/js-ipld-dag-pb/blob/master/src/dag-node/index.js#L51-L53 wonder if you changed something in your codebase that tries to change the links property.

You can still use the class functions as you could before, such as .addLink, see docs at https://github.com/ipld/js-ipld-dag-pb#table-of-contents

[pgte]

I’ve caught this one too, and it happens if I have no Swarm addresses set.

…

On 7 Dec 2017, 18:32 +0000, David Dias ***@***.***>, wrote: @haadcode that property has been immutable for a while https://github.com/ipld/js-ipld-dag-pb/blob/master/src/dag-node/index.js#L51-L53 wonder if you changed something in your codebase that tries to change the links property. You can still use the class functions as you could before, such as .addLink, see docs at https://github.com/ipld/js-ipld-dag-pb#table-of-contents — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[daviddias]

@pgte @haadcode can you create a repro case to test it out?

[haadcode]

This only happens with a minified build of ipfs (dist/index.min.js). Will try to provide a simple test case, but this sounds like uglify (or webpack) issue.

[haadcode]

If I pull js-ipfs from master, build it and npm link it to the project this is happening, the error is gone. Will investigate more.

git clone https://github.com/ipfs/js-ipfs.git
cd js-ipfs/
npm install && npm run build

Produces dist/ipfs.min.js that works and the error doesn't come up.

npm install ipfs

And using dist/ipfs.min.js from the npm package produces the aforementioned error.

@diasdavid perhaps something went funky in the release and the up-to-date dist file was not included?

[daviddias]

Seems that #1136 also had issues. Let me try to publish again.

[daviddias]

@haadcode could you try with latest?

[haadcode]

@diasdavid I can confirm that it still happens with 0.27.3 :/ Using dist/index.min.js produces the aforementioned error while dist/index.js works as expected.

However, I have good news, I think :) I was able to get everything working correctly with webpack, compiling and uglifying orbitdb and ipfs together, by setting the mangle and compress flags to false:

const uglifyOptions = {
  uglifyOptions: {
    mangle: false,
    compress: false,
  },
}

When uglified non-compressed, it seems to work as expected while still minifying the output bundle. So what I take from this is that in order to fix dist/index.min.js, it should be uglified without compressing it? Or find out why compressing it is now causing it to throw an error. Perhaps changes in Uglify?