Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Tests on Windows #1075

Closed
richardschneider opened this issue Nov 14, 2017 · 7 comments
Closed

Tests on Windows #1075

richardschneider opened this issue Nov 14, 2017 · 7 comments
Assignees
Labels
env:Windows exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up

Comments

@richardschneider
Copy link
Contributor

The path /tmp/... does not exist on windows. Use path.join(os.tmpdir(), '...').

See some possible bad tests

@daviddias
Copy link
Member

@richardschneider Now that you pushed Windows support, do you want to share an update here on your plans to fix the tests to make sure Appveyor is happy?

@richardschneider
Copy link
Contributor Author

First, I'll change all tests not to use /tmp/....

Next change is harder. It seems that NPM likes to randomly throw EPERM every now and then. I've even seen it once or twice on my local machine.

According to Medium/phantomjs#19 it may be Windows Anti-Virus software; which I consider a virus in itself.

@richardschneider richardschneider self-assigned this Dec 4, 2017
@richardschneider
Copy link
Contributor Author

richardschneider commented Dec 4, 2017

Also npm/npm#18380 (comment) suggests downgrading NPM

Another idea from npm/npm#17747 is to use yarn

@richardschneider
Copy link
Contributor Author

@victorbjelkholm have you seen any of these EPERM errors on Jenkins Windows build?

@victorb
Copy link
Member

victorb commented Dec 4, 2017

@richardschneider yes indeed I've seen those errors that happened every once in a while. The only reliable solution I've found is to turn off real time protection in Windows Defender.

In Powershell, you can disable it like this: Set-MpPreference -DisableRealtimeMonitoring $true

From https://github.com/ipfs/jenkins/blob/a73cb56893a80427ce0e87601ef1dcb8326222f0/worker/main.tf#L220

@victorb
Copy link
Member

victorb commented Dec 4, 2017

For the record, ended up going with Yarn as it handles concurrent installs better than npm. But, got those errors with Yarn as well, unless turning off the real-time protection.

@daviddias daviddias added status/ready Ready to be worked exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up labels Jan 25, 2018
@daviddias
Copy link
Member

Lot's of work happening on #1103

@ghost ghost removed the status/ready Ready to be worked label Mar 16, 2018
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
env:Windows exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

3 participants