Avoid blocking on empty requests

ipfs · Mar 3, 2016 · 5176fa5 · 5176fa5
1 parent 493f51b
commit 5176fa5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/lib/parser.js b/lib/parser.js
@@ -60,6 +60,11 @@ Parser.prototype._transform = function (chunk, enc, cb) {
   cb()
 }
 
+Parser.prototype._flush = function (cb) {
+  this.dicer.end()
+  cb()
+}
+
 Parser.prototype.handlePart = function (part) {
   part.on('header', (header) => {
     const partHeader = parseHeader(header)

diff --git a/test/parser.js b/test/parser.js
@@ -145,4 +145,22 @@ describe('parser', () => {
       })
     })
   })
+
+  describe('empty', () => {
+    before(() => {
+      handler = (req, cb) => {
+        expect(req.headers['content-type']).to.be.a('string')
+        const parser = IPFSMultipart.reqParser(req)
+
+        parser.on('end', cb)
+      }
+    })
+
+    it('does not block', (done) => {
+      request.post({ url: `http://localhost:${PORT}` }, (err, httpResponse, body) => {
+        expect(err).not.to.exist
+        done()
+      })
+    })
+  })
 })