feat: detect support for WebRTC data channels #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPFS' use of WebRTC is only as a data channel, we don't use getUserMedia and sometimes the user has restricted access to this API so add a 'supports' test that is just for data channels. Fixes #50
jacobheun
approved these changes
Aug 12, 2020
test/supports.spec.js
Outdated
| } | ||
| }) | ||
|
|
||
| it('supportsWebRTCDataChannels should return true in Web Worker', function () { |
There was a problem hiding this comment.
Suggested change
| it('supportsWebRTCDataChannels should return true in Web Worker', function () { | |
| it('supportsWebRTCDataChannels should return false in Web Worker', function () { |
There was a problem hiding this comment.
I've changed the name of the supportsWebRTC webworker test as that was wrong too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of WebRTC in IPFS is only as a data channel, we don't use getUserMedia and sometimes the user has restricted access to this API so add a 'supports' test that is just for data channels.
Fixes #50