This repository was archived by the owner on Mar 23, 2023. It is now read-only.
fix: wrap operations in transactions #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get a cursor to operate over a set of keys from an idb store, you have to start a transaction. That transaction will remain open as long as there are tasks in the microtask queue - when it empties the transaction is automatically closed. Transactions operate on an ObjectStore, puts and gets not to the object store also seem to close the transaction. This change adds a `_getObjectStore` method to the datastore which creates a new transaction if there was no previous transation, or if the previous transaction was closed. All operations then take place as part of this transaction.
achingbrain
force-pushed
the
fix/wrap-operations-in-transaction
branch
from
57522e9 to
807e425
Compare
|
This branch integrated with:
|
achingbrain
force-pushed
the
fix/wrap-operations-in-transaction
branch
from
fb5bed4 to
5c7f97b
Compare
Still not 100% on this as you could in theory cause the transaction to close by mutating the datastore while the cursor was being opened or advanced but it's a start.
Closed
autonome
added
status/blocked
|
We still need something like this to fix ipfs/js-stores#198 but this PR is now really out of date |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a cursor to operate over a set of keys from an idb store, you
have to start a transaction. That transaction will remain open as long
as there are tasks in the microtask queue - when it empties the
transaction is automatically closed.
Transactions operate on an ObjectStore, puts and gets not to the object
store also seem to close the transaction.
This change adds a
_getStoremethod to the datastore whichcreates a new transaction if there was no previous transaction, or if
the previous transaction was closed. All operations then take place as
part of this transaction.