App version is taken from version.json compiled in#149
Merged
Conversation
MarcoPolo
approved these changes
Aug 15, 2024
aschmahmann
reviewed
Aug 15, 2024
aschmahmann
approved these changes
Aug 15, 2024
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
LGTM, thanks. Left one comment.
Would be nice if there was a way to only use the tag if the commit matched the tag instead of always adding the commit, but IIUC you can't do that from the build information alone (probably something about how Go wants to pretend Git tags are immutable while also knowing that they're actually not). (e.g. you need to do things like https://github.com/mvdan/sh/blob/ccc828fc563fc884e664f11a62427025f74106af/cmd/shfmt/Dockerfile#L6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the version is always set to the correct value. making version.json the source of truth.
Fixes #146
Fixes #113