fix: new filter component on peers page should support i18n

ipfs-webui/src/peers/PeersTable/PeersTable.js

Lines 104 to 117 in b8a71d9

    
           const FilterInput = ({ setFilter, t, filteredCount }) => { 
        
             return ( 
        
               <div className='flex items-center justify-between pa2'> 
        
                 <input 
        
                   className='input-reset ba b--black-20 pa2 mb2 db w-100' 
        
                   type='text' 
        
                   placeholder='Filter peers' 
        
                   onChange={(e) => setFilter(e.target.value)} 
        
                 /> 
        
                 {/* Now to display the total number of peers filtered out on the right side of the inside of the input */} 
        
                 <div className='f4 charcoal-muted absolute top-1 right-1'>{filteredCount}</div> 
        
               </div> 
        
             ) 
        
           }

@whizzzkid

Also from @whizzzkid on slack:

This is beautiful [...] maybe Filter Peers could be Search Peers, because it’s not filter per se, i.e. say filtering peers with latency >25ms is not possible (yet!)

It's only filtering what peers are shown, but after Nishant said this I haven't liked "filter peers" nor "search peers".

Maybe we need something like "Find peers in table" or "search for peers in peers table"

Navigation Menu

Repository navigation

fix: new filter component on peers page should support i18n #2186

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const FilterInput = ({ setFilter, t, filteredCount }) => {
	return (
	<div className='flex items-center justify-between pa2'>
	<input
	className='input-reset ba b--black-20 pa2 mb2 db w-100'
	type='text'
	placeholder='Filter peers'
	onChange={(e) => setFilter(e.target.value)}
	/>
	{/* Now to display the total number of peers filtered out on the right side of the inside of the input */}
	<div className='f4 charcoal-muted absolute top-1 right-1'>{filteredCount}</div>
	</div>
	)
	}

fix: new filter component on peers page should support i18n #2186

Description

Activity

SgtPooki commented on Dec 8, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions