Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.12.0-rc1 fails during blockstore migration #151

Closed
overpi opened this issue Dec 19, 2021 · 4 comments · Fixed by #155
Closed

Update to v0.12.0-rc1 fails during blockstore migration #151

overpi opened this issue Dec 19, 2021 · 4 comments · Fixed by #155
Assignees

Comments

@overpi
Copy link

overpi commented Dec 19, 2021

$ sudo ipfs-update install v0.12.0-rc1
fetching go-ipfs version v0.12.0-rc1
binary downloaded, verifying...
install failed, reverting changes...
ERROR: test refs list: expected to see QmTFJQ68kaArzsqz2Yjg1yMyEA5TXTfNw6d9wSFhxtBxz2 in the local refs! 

I'm not sure what this particular CID might be, but its existence seems to be tested for during blockstore migrations:

exp := "QmTFJQ68kaArzsqz2Yjg1yMyEA5TXTfNw6d9wSFhxtBxz2"

@welcome
Copy link

welcome bot commented Dec 19, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@overpi
Copy link
Author

overpi commented Dec 19, 2021

I discovered the source of the problem. The test function is looking for the Qm hash and v0.12.0-rc1 only outputs the base32 hashes... bafy...

Tested by pausing the installation before the end of the script.

/ipfs-new -c . add -

hello world! This node should workCTRL-D

Outputs the expected QmTFJQ68kaArzsqz2Yjg1yMyEA5TXTfNw6d9wSFhxtBxz2

And:

/ipfs-new cid format -v 1 -b base32 QmTFJQ68kaArzsqz2Yjg1yMyEA5TXTfNw6d9wSFhxtBxz2

bafybeici5oilk5bkifyzsbo7bdgwl246a2t53ejm44ektaqrsl3ye7dwy4

So, the script will probably function if there is a test for which version is being installed. If >= v0.12 then bafy...

Stebalien added a commit that referenced this issue Dec 28, 2021
This fix works all the way down to go-ipfs 0.4.21, so it should be
acceptable.

fixes #151
@Stebalien
Copy link
Member

@overpi does #153 fix it?

@BigLep
Copy link

BigLep commented Jan 6, 2022

2022-01-06 discussion:

  1. We need a sharness test for this.
  • Ideally in the sharness, we want to dynamically fetch the latest.
  1. Potentially don't go back in the past for sharness.
  2. Link Gus PR to this and potentially close Steven's.

@guseggert guseggert linked a pull request Jan 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants