feat: run garbage collector #1407
Conversation
hacdias
added
the
kind/enhancement
There was a problem hiding this comment.
A few nitpicks in text 😊 and two questions:
- Will it ever NOT run successfully? If so, how does the user know? If not, maybe the languages should just be “garbage collection run finished” or similar.
- I assume it runs in the background so user can still work during “it may take a while”?
Thanks!
|
Thanks for the copy feedback @jessicaschilling!
I believe it's unlikely, but it may happen. And yes, the user will end up knowing. We'll tell them that an error occurred and ask them if they'd like to open an issue here with the error report (which is generated automatically!)
Yes! |
|
Awesome, thanks for clarifying! |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
Is there a progress bar or a wait icon of some kind? Since the operation can take extremely long if the datastore is large or the disk is slow. |
|
No, but I was thinking of changing the tooltip while it's running so the user knew:
What do you think? |
|
Uh, I have an idea with better UX. Will get back with a PR. |
Supports running the GC from the menubar. This was a feature that was lost during the revamp. Closes #1355.
Note: the Electron icon is replaced by IPFS Desktop's icon on the final version.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com