ipfsd not stopped when quitting app from OS

[hacdias]

Yesterday I installed a binary with the latest version from master, on Windows, and I set it to startup on login. Since IPFS Desktop doesn't shutdown correctly when Windows turns off, I always get this message:

I didn't found, yet, a way to listen for Windows shutdown but there must be a way because I know that many apps can even prevent Windows from turning off.

[olizilla]

Also the app does not start cleanly after choosing the fsck option on osx. The menubar appears, but the node is displayed as offline. Quiting the app brings up the fsck dialog again, and then same proess repeats.

[hacdias]

NOTE TO SELF: https://github.com/electron/electron/blob/master/docs/api/power-monitor.md

[hacdias]

So, there is no shutdown listener for Windows (see issue here: electron/electron#12810). Will use it for Linux and macOS. For Windows I'll try to find a workaround.

[hacdias]

macOS and Linux

We can play with shutdown event from PowerMonitor. More info here: https://github.com/electron/electron/blob/master/docs/api/power-monitor.md#event-shutdown-linux-macos

Windows

We can play with .NET code and make it listen for the shutdown event. There are libraries to include .NET code on Node.js such as Edge.

---

I can work on the Windows fix. Anyone willing to fix the macOS/Linux one? (not using any of the OSes ATM)

[olizilla]

i'll experiement with the osx shutdown logic.

[olizilla]

@hacdias before you get too deep into .NET code, have you tried listening to the before-quit event on windows?

[hacdias]

@olizilla I didn't. The docs say:

Note: On Windows, this event will not be emitted if the app is closed due to a shutdown/restart of the system or a user logout.

[hacdias]

May not need .NET. Just some C++.

[olizilla]

i think the problem here is we can't guarantee that the ipfd will ever be shutdown cleanly. We should what we can to shut it down, but there will be times when it's just not possible. Right now the ipfs daemon command will run just fine if there is an api file left over in the repo but ipfsd-ctl won't.

I think we have to go back to having desktop run some clean up logic if it finds the repo has evidence of an unclean shutdown. We've already got a couple of suggesitions to consider

• @Stebalien's proposal in feat: cleanup repository before starting up IPFS #722 (comment)
• @dryajov's propsoal in Trying to start non-disposable node fails on second attempt js-ipfsd-ctl#226 (comment)

[olizilla]

Of note running ipfs daemon also works fine if there is a repo.lock and a api file in the repo!

We should make ipfsd-ctl as robust as ipfs daemon is!

[olizilla]

@hacdias ipfs/js-ipfsd-ctl#315 - an issue for making ipfsd-ctl as robust as running ipfs daemon is. I think that would solve the core of our problem here. We'd try and shutdown gracefully where possible, but the app should still start next time if we fail.

cc @lidel

[hacdias]

@olizilla I think we should go for @Stebalien's proposal while js-ipfsd-ctl is not able to handle this situation. I can work on adding that logic in Desktop. What do you think?