fix: ignore libp2p start param in helia factory #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
approved these changes
Jan 16, 2024
SgtPooki
approved these changes
Jan 16, 2024
Omits the `start` key from the accepted libp2p init params, instead use only the `start` key in the main Helia init object. Fixes #344
achingbrain
force-pushed
the
fix/ignore-libp2p-start-param
branch
from
c68c63e
to
80e296d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omits the
startkey from the accepted libp2p init params, instead use only thestartkey in the main Helia init object.Fixes #344