-
Notifications
You must be signed in to change notification settings - Fork 53
create internal and private packages #108
create internal and private packages #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use internal, private
or similar works better and doesnt punish people for no reason.
e42b09f
to
b9b823b
Compare
@whyrusleeping this is exclusively used for testing. However, it seems fine to move a utility creating a full HAMT into a package called However, #99 has some changes that I would like to move into the internal package such as a flag for being able to change the hash function used by the HAMT shards (e.g. to the identity function for testing). I do not want people to think that that's something they can do without it being really inconvenient for them. At the moment UnixFS only supports are particular brand of murmur3 and nothing else. @schomatis could you move the CreateCompleteHAMT into a |
b9b823b
to
6161095
Compare
@aschmahmann Refactored into both packages. Can you take another look, please? |
First attempt at using the internal package to reduce unnecessary API exposure. After this is merged we can evaluate moving other artifacts from the shard testing if necessary.