Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Aug 9, 2021

From #94 (comment).

Should be reivewed after #102 (on which it's based), the only new commit is a1107a8.


Check for a potential size drop and a HAMT-to-Basic switch even in the add-entry case as it may overwrite an old entry of bigger size.

  • Extend needsToSwitchToBasicDir to accommodate for both add/remove operations.
  • Include HAMT switch logic in (UpgradeableDirectory).AddChild().

@schomatis schomatis mentioned this pull request Aug 9, 2021
4 tasks
@schomatis schomatis changed the base branch from master to schomatis/directory/unsharding August 9, 2021 14:44
@schomatis schomatis force-pushed the schomatis/directory/unsharding-split/add-unshadring-for-addchild branch from 0dbfece to a1107a8 Compare August 11, 2021 18:44
@schomatis schomatis marked this pull request as ready for review August 11, 2021 18:46
@schomatis schomatis mentioned this pull request Aug 11, 2021
@aschmahmann aschmahmann changed the base branch from schomatis/directory/unsharding to schomatis/directory/unsharding-split/remove-timeout-refactor August 12, 2021 01:30
io/directory.go Outdated Show resolved Hide resolved
io/directory.go Outdated Show resolved Hide resolved
io/directory.go Outdated Show resolved Hide resolved
io/directory.go Outdated Show resolved Hide resolved
@schomatis
Copy link
Contributor Author

I shouldn't have "dismissed" the review, sorry. I didn't know it would delete history.

@schomatis schomatis force-pushed the schomatis/directory/unsharding-split/add-unshadring-for-addchild branch from 79bf603 to 1fa29a9 Compare August 25, 2021 17:20
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll go through another round once all the pieces are together but looks good.

Base automatically changed from schomatis/directory/unsharding-split/remove-timeout-refactor to schomatis/directory/unsharding August 26, 2021 16:32
@schomatis schomatis force-pushed the schomatis/directory/unsharding-split/add-unshadring-for-addchild branch from 1fa29a9 to 7a7204f Compare August 26, 2021 16:40
@schomatis schomatis force-pushed the schomatis/directory/unsharding-split/add-unshadring-for-addchild branch from 7a7204f to 16a96a3 Compare August 26, 2021 16:42
@schomatis schomatis merged commit efd7822 into schomatis/directory/unsharding Aug 26, 2021
@schomatis schomatis deleted the schomatis/directory/unsharding-split/add-unshadring-for-addchild branch August 26, 2021 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants