Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RawNode incomplete stats #75

Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix RawNode incomplete stats #75

merged 1 commit into from
Sep 23, 2021

Conversation

MichaelMure
Copy link
Contributor

As far as I understand there is no reason not to return proper values here.

@aschmahmann
Copy link

This looks right to me. @Stebalien anything arcane here that I'm missing?

Stebalien
Stebalien approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems totally reasonable and I have absolutely no idea why it wasn't implemented before (or why this function even exists...)

@aschmahmann aschmahmann merged commit 9979f9a into ipfs:master Sep 23, 2021
@MichaelMure MichaelMure mentioned this pull request Sep 29, 2021
Closed
62 tasks
@BigLep BigLep mentioned this pull request Sep 30, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelMure @aschmahmann @Stebalien