Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in dagutils MergeDiffs. #59

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Fix bug in dagutils MergeDiffs. #59

merged 3 commits into from
Jan 6, 2021

Conversation

nasdf
Copy link
Contributor

@nasdf nasdf commented Nov 29, 2020

This fixes a bug where conflicts were also returned as changes when merged.

@welcome
Copy link

welcome bot commented Nov 29, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@rvagg
Copy link
Member

rvagg commented Dec 2, 2020

I think this is OK, but would you mind trying to add a simple test case for it?

@nasdf
Copy link
Contributor Author

nasdf commented Dec 3, 2020

Yeah I'll update when I have some free time this week.

@nasdf
Copy link
Contributor Author

nasdf commented Dec 5, 2020

@rvagg I cleaned up the diff function and added some tests for it as well. Hopefully this all looks good and can be merged soon.

@nasdf
Copy link
Contributor Author

nasdf commented Dec 31, 2020

@Stebalien Can you take a look at this?

@aschmahmann
Copy link

@nasdf a lot of people are unavailable over the next little bit due to holidays (Dec - Jan is frequently rough for getting things merged in). Things should start picking back up later this month and then we can hopefully get this taken care of.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice code cleanup in general, and tests, and I think it's just the single delete that might be doing all of the fix work here, so thanks for going the extra mile! lgtm.

@rvagg rvagg merged commit bf51443 into ipfs:master Jan 6, 2021
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants