Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize paths on windows #74

Merged
merged 2 commits into from
Mar 24, 2020
Merged

fix: normalize paths on windows #74

merged 2 commits into from
Mar 24, 2020
+52 −2

Commits on Mar 24, 2020

  1. fix: normalize paths on windows 

    Fixes #73 by normalizing paths to UNC on windows. This is _slightly_ less hacky
than registering a new schema.

The underlying issue was twofold:

1. When specifying a windows file URL as `file://c:/foo/bar`, go barfs because
`:` can't be in a domain name.
2. When specifying a windows file URL as `file:///c:/foo/bar`, we'd end up
trying to open `/c:/foo/bar` which is actually `CURRENT_DRIVE:/c:/foo/bar`.
    @Stebalien
    Stebalien committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    45b384f View commit details
    Browse the repository at this point in the history

  2. use escaped question mark for UNC paths

    @aschmahmann
    aschmahmann committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    be98d3d View commit details
    Browse the repository at this point in the history