This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Add test to maintain Put contract of calling Has first #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazow
force-pushed
the
blockstore-put-tst
branch
from
fea5be7
to
d840184
Compare
shazow
force-pushed
the
blockstore-put-tst
branch
from
d840184
to
9a3ae2a
Compare
|
While it's an important optimization, it's not a part of the contract. Is it not possible to fix your datastore? |
|
We could, but at a non-trivial performance cost: (local call potentially cached) vs (local call potentially cached) + (remote call) Not asking for this behavior to be part of the contract, just to be notified if it ever change. |
|
Fair enough. |
|
(I mean, this is so much better than our usual "we know this works, don't touch it" approach) |
Both @shazow and I are open source maintainer, we know what's up :) |
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…put-tst Add test to maintain Put contract of calling Has first This commit was moved from ipfs/go-ipfs-blockstore@6486d67
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I'm working with @MichaelMure on some of Infura's IPFS backend, and we realized that we're relying on the implementation detail of blockstore that
PutchecksHasfirst. I want to add a test to maintain this implementation detail, or at least inform us if it's going to go away so we can prepare for it.