P0 Bug: Dropping extensions in response messages #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve issue where extensions may get droppped from graphsync messages
hannahhoward
force-pushed
the
fix/message-building
branch
from
05ef03b
to
b71304d
Compare
gammazero
approved these changes
Sep 4, 2021
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* fix: disable restart ack timeout * fix: option to disable accept and complete timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
If a response is built with extensions but NO other data, it can get dropped, because of a bug where we're not marking an outgoing response needing to get sent. This is most likely to happen when there are multiple responses being sent between the same requestor and responder.
Note: we should refactor this builder code cause I think it's weird that we're determining responses based on who has metadata. That being said, best to get this fixed for now.