Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnlimitedSimultaneousOutgoingRequests startup option via an "execute immediately" TaskQueue #233

Open
hannahhoward opened this issue Sep 29, 2021 · 0 comments
Open

Add UnlimitedSimultaneousOutgoingRequests startup option via an "execute immediately" TaskQueue #233

hannahhoward opened this issue Sep 29, 2021 · 0 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up

Comments

@hannahhoward
Copy link
Collaborator

Goals

Since the task queue interface is very abstract, it'd be super awesome to have a version that takes an executor at instantiation, and when you call PushTask, just kicks of a go routine to execute it immediately. Essentially, it's an "unbounded parallelism" task queue, which was the previous behavior of the RequestManager to begin with.

You could then add an UnlimitedSimultaneousOutgoingRequests option to graphsync, maybe an UnlimitedSimultaneousIncomingRequests as well.
@hannahhoward hannahhoward added P2 Medium: Good to have, but can wait until someone steps up exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week labels Sep 29, 2021
marten-seemann pushed a commit that referenced this issue Mar 2, 2023
@aarshkshah1992
Handle data-sent and data-queued events in the TransferFinished state (…
8931e01 
…#233)

* handle data-sent and data-queued events in the TransferFinished state

* go fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannahhoward