fix: ensure graphsync transport only closes complete channel once (#250)

ipfs · Sep 2, 2021 · bcace47 · bcace47
1 parent b0599c7
commit bcace47
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/transport/graphsync/graphsync.go b/transport/graphsync/graphsync.go
@@ -894,9 +894,13 @@ func (c *dtChannel) open(ctx context.Context, chid datatransfer.ChannelID, dataS
 	// Set up a completed channel that will be closed when the request
 	// completes (or is cancelled)
 	completed := make(chan struct{})
+	var onCompleteOnce sync.Once
 	onComplete := func() {
-		log.Infow("closing the completion ch for data-transfer channel", "chid", chid)
-		close(completed)
+		// Ensure the channel is only closed once
+		onCompleteOnce.Do(func() {
+			log.Infow("closing the completion ch for data-transfer channel", "chid", chid)
+			close(completed)
+		})
 	}
 	c.completed = completed