Query parameter used instead of body for Reframe requests

[aschmahmann]

Is this a holdover from before we merged the Reframe spec?

go-delegated-routing/gen/proto/proto_edelweiss.go

Line 1620 in 3729ba3

msg := request.URL.Query().Get("q")

The spec indicates this should be in the body of the POST request (cc @lidel I think this was your suggestion when we did the spec change).
https://github.com/ipfs/specs/blob/6bdb7b2751038e1d0212a40494ea8fd4018f384c/REFRAME.md?plain=1#L46

[petar]

It looks like it. I'll start a PR.

[lidel]

@aschmahmann @petar query should be removed 👍 but we may want to support GET for improved HTTP caching – see proposal in ipfs/specs#287

[petar]

@thattommyhall @willscott FYI, I made a change to Reframe implementation which moves the query parameters from the URL to the HTTP body to follow the Reframe spec more closely (this issue). As a result, we'll have to redeploy the hydra-indexer connection, after the Hydra (libp2p/hydra-booster#170) and Indexer (ipni/storetheindex#563) update PRs are merged.

[petar]

This feature is implemented and merged. We will wait on redeploying until the ipfs/specs#282 is also resolved. Closing this issue here as done.