generated from ipdxco/github-as-code
-
Notifications
You must be signed in to change notification settings - Fork 24
Reduce org owners/admins #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
28adbae
Update ipfs.yml - reduce org owners/admins
BigLep f2a01ba
fix@7875238694 [skip fix]
BigLep 1a604d1
Update ipfs.yml - readded vesahc
BigLep 17b6183
Update ipfs.yml - cleanup github-mgmt team.
BigLep 389bb1f
fix@7880486036 [skip fix]
BigLep e3b793c
Merge branch 'master' into biglep-reduce-org-owners-2024q1
ipfs-mgmt-read-write[bot] 40d6004
fix@7905104937 [skip fix]
ipfs-mgmt-read-write[bot] fa8341e
Merge branch 'master' into biglep-reduce-org-owners-2024q1
galargh d085d34
Update github/ipfs.yml
BigLep 3ae7fc1
Further reduce github org owners
BigLep aae46cb
fix@7924838401 [skip fix]
BigLep 1729730
fix typo
BigLep 07e8ba6
Update ipfs.yml
BigLep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to specific individuals but is this a good enough reason?
Group membership here gives perms to create/delete/configure repos and mess with the GH org in general, if people aren't doing these essentially administrative tasks with reasonable frequency, why do they have the perms to do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair callout @achingbrain - makes sense.
I was biasing here to make sure we had some more organizational diversity which is why I pulled in the IPFS Foundation.
Folks on this "github-mgmt stewards" team also have access to all security incidents reported through github, which seems appropriate for the IPFS Foundation to have insight on.
Github only allows for one team to be "security manager" though.
Using "github-mgmt stewards" is a shortcut, but in thinking more, it should ideally be its own team with high overlap with "github-mgmt stewards".
Given I'm out of time in this season to push on this further, I'm going to propose we go with what we currently have as its still better than what was there before, and future improvements can be made later.