feat: update t0114 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsenta
force-pushed
the
feat/update-t0114
branch
2 times, most recently
from
7ef5724 to
b067e32
Compare
laurentsenta
commented
May 23, 2023
|
|
||
| return ipns.ValidateWithPeerID(id, i.pb) | ||
| func (i *IpnsRecord) B58MH() string { | ||
| return i.id.String() |
There was a problem hiding this comment.
Highlight: I'm not a super fan of this, it relies on internal details of libp2p I think, but I haven't found a reusable piece of code to do this.
There was a problem hiding this comment.
@laurentsenta check ipfs/boxo#339 – @hacdias refactored and added some UX improvements around ipns.Record.
There was a problem hiding this comment.
Thanks for the note, I logged that as an item in #8, we'll review once the PR is merged!
laurentsenta
commented
May 23, 2023
| // panic(err) | ||
| // } | ||
| // return s | ||
| } |
There was a problem hiding this comment.
Highlight: I couldn't find a reusable way to do this, so I copied some code out of libp2p.
20 tasks
laurentsenta
force-pushed
the
feat/update-t0114
branch
6 times, most recently
from
6b0a69e to
785191d
Compare
laurentsenta
force-pushed
the
feat/update-t0114
branch
from
6373fef to
3531901
Compare
galargh
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.