-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make clean and docker cleanup #110
Conversation
- adds 'make clean' that removes artifacts - improves ux when working with docker, especially when image is missing - 'make' only builds the binary, kubo logic needs to be explicitly called
Makefile
Outdated
find ./fixtures -name '*.car' -exec ipfs dag import {} \; | ||
find ./fixtures -name '*.ipns-record' -exec sh -c 'ipfs routing put --allow-offline /ipns/$$(basename -s .ipns-record "{}") "{}"' \; | ||
find ./fixtures -name '*.car' -exec ipfs dag import --stats --pin-roots=false {} \; | ||
find ./fixtures -name '*.ipns-record' -exec sh -c 'ipfs routing put --offline --allow-offline /ipns/$$(basename -s .ipns-record "{}") "{}"' \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 iiuc this makes put
finish instantly, and not block on putting each record to 20 peers
Makefile
Outdated
@@ -15,8 +22,8 @@ provision-cargateway: ./fixtures.car | |||
car -c ./fixtures.car & | |||
|
|||
provision-kubo: | |||
find ./fixtures -name '*.car' -exec ipfs dag import {} \; | |||
find ./fixtures -name '*.ipns-record' -exec sh -c 'ipfs routing put --allow-offline /ipns/$$(basename -s .ipns-record "{}") "{}"' \; | |||
find ./fixtures -name '*.car' -exec ipfs dag import --stats --pin-roots=false {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ pinning blocks on things like missing blocks (#85) – we don't need to pin, as GC is not enabled by default in Kubo
Some changes I made locally to make local dev easier: