Skip to content

Conversation

@laurentsenta
Copy link
Contributor

  • fix tooling test suite
  • run go test tooling
  • more explicit workflow names

@laurentsenta laurentsenta marked this pull request as draft June 30, 2023 14:24
@laurentsenta
Copy link
Contributor Author

laurentsenta commented Jun 30, 2023

@galargh I'm thinking about dogfooding unified CI with this repo, but I don't want to run the test in ./tests: that's the project's output, they need provisioning, running daemons, etc. more like an e2e test suite.

I'm thinking either

  1. we add build tags support, similar to skip32bit in configuration ,
  2. we just remove the ./tests folder during the setup actions.

(1) might not be useful outside of gway conformance and (2) seems to just work ¯\(ツ)/¯, wdyt?

@galargh
Copy link
Contributor

galargh commented Jul 3, 2023

That's a swell idea! I think we should go with 2. (at least for now). The main reason is quite selfish, we need to do a looot of changes in uCI in July to get us closer to protocol/.github#514 before Go 1.21 is out so if we can limit other changes in the meantime, that's great. Also, if we have uCI in Gateway Conformance, it'll be extremely useful for testing if our changes to uCI as a whole work as expected :)

@laurentsenta laurentsenta marked this pull request as ready for review July 3, 2023 11:17
@laurentsenta laurentsenta merged commit 83c659a into main Jul 3, 2023
@laurentsenta laurentsenta mentioned this pull request Jul 3, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants