Skip to content

Do not ignore arguments #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Do not ignore arguments #130

merged 1 commit into from
Apr 12, 2021

Conversation

gammazero
Copy link
Contributor

This fixes issue #11

After fix:

> fs-repo-migrations/fs-repo-migrations sdff sdfsf sdfsdf
unrecognized arguments
Usage of fs-repo-migrations/fs-repo-migrations:
  -distpath string
        specify the distributions build to use
  -revert-ok
        allow running migrations backward
  -to string
        repo version to upgrade to, or "latest" for latest repo version (default "latest")
  -v    print latest migration available and exit
  -y    answer yes to all prompts

This fixes issue #11
@Stebalien Stebalien merged commit 280b5e7 into master Apr 12, 2021
@Stebalien Stebalien deleted the fix/dont-ignore-arguments branch April 12, 2021 17:50
@hsanjuan
Copy link
Contributor

I think this broke tests in master @gammazero @Stebalien

@gammazero
Copy link
Contributor Author

@hsanjuan That is surprising, since should only complain about arguments that should not be present anyway. Running make test in master branch is passing for me. What tests appear broken?

One thing to be careful of is that some of the tests do not put the test bin directory first in PATH, so if you have existing versions of certain binaries that already in PATH, it is these versions that are run and not the test versions.

@hsanjuan
Copy link
Contributor

The tests did not pass for the commit above, and since merge they do not pass in master, so something broke, perhaps it is not related to this PR but this was still merged with broken CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants